Home
release-team@conference.openafs.org
Friday, November 15, 2019< ^ >
Room Configuration
Room Occupants

GMT+0
[12:02:04] mbarbosa joins the room
[14:51:53] meffie joins the room
[16:58:55] yadayada joins the room
[17:00:55] <meffie> good evening.
[17:01:37] <yadayada> Hello All
[17:03:20] <meffie> I expect this will be a rather short meeting.
[17:06:07] <meffie> Ben is not available today. Not sure if Stephan is able to attend.
[17:06:53] <yadayada> ok
[17:07:21] <meffie> i
[17:07:37] <meffie> i will try to do weisand's normal agenda.
[17:07:45] <yadayada> sure
[17:09:21] <meffie> first 1.6.x; the patches are all in gerrit for the next 1.6.25pre1 release. todo: reviews, the fix for volume init stuff (fixed on master now), and an updated NEWS
[17:10:01] <yadayada> which reviews are pending ? Can I help with some reviews ?
[17:11:39] <meffie> https://gerrit.openafs.org/#/c/13937/
[17:12:01] <meffie> needs to be reviewed and accepted on 1.8.x. it is blocking the 1.6.x release
[17:13:10] <meffie> the other gerrits to be reviewed are: https://gerrit.openafs.org/#/q/status:open+branch:openafs-stable-1_6_x
[17:13:41] <meffie> that's all i know about 1.6.x
[17:14:31] <meffie> yadayada: do you have anything else to discuss about 1.6.25pre1?
[17:14:45] <yadayada> ok I can take some reviews. Will go through list and will let you know which gerrit I can go through
[17:14:54] <meffie> thanks!
[17:15:13] <meffie> next; openafs 1.8.x
[17:15:29] <yadayada> ok
[17:15:34] <meffie> we already mentioned 13937
[17:16:28] <meffie> looks like we also need to review 13938
[17:16:49] <yadayada> yes I had look at 13937 last week, and it looked good to me
[17:17:42] <meffie> ok, thanks!
[17:17:55] <meffie> also 13893 seems important for 1.8.x
[17:18:22] <meffie> that is a change for the fileserver
[17:18:55] <yadayada> 13938 seems resonable. I am not sure how we simulate error condition here. I think we can inject error using systemTap and see how this patch works. Will try to test it
[17:19:04] wiesand joins the room
[17:19:35] <meffie> thanks! and 13765 looks interesting for 1.8.x
[17:19:40] <meffie> welcome wiesand
[17:19:56] <wiesand> my apologies…
[17:20:14] <wiesand> reading up..,
[17:22:34] <meffie> (i'll give wiesand some time to read)
[17:22:36] <wiesand> ok
[17:23:06] <wiesand> re 1.6: thanks a lot for all the work!
[17:23:49] <yadayada> 13765 looks important, as pages can be locked forever. Fix looks resonable. I will give one try to a patch and see if I find something interesting
[17:24:07] <meffie> thanks!
[17:24:24] <yadayada> Also can akimpersonate patches which I submitted sometime back, can make it way to 1.8.* release ?
[17:24:47] <meffie> oh that would be nice!
[17:25:27] <meffie> can you remind me the gerrit numbers? (or a topic?)
[17:25:42] <wiesand> but it's a lot of stuff lined up for such a late old-stable release, and I still have problems with changes like "remove -settime" and "remove the sync thread" this late in the old-stable series
[17:26:06] <yadayada> 13827, 13828
[17:26:22] <wiesand> anyway, my focus for the next week would be on the next 1.8 prerelease
[17:26:59] <meffie> thanks. should i abandon the gerrits for the old topic "akimpersonate-on-master-again" ? (4 changes)
[17:28:07] <yadayada> yes those will not be required now
[17:29:10] <meffie> thanks yadayada, i'll mark those as 'abandoned'
[17:30:08] <meffie> weisand if you want to mark the ones you do not think are appropriate for 1.6.x with a -1 or -2, i'll rebase around them!
[17:30:31] <meffie> and then we can get them off the board
[17:31:49] <wiesand> The 1.8 queue is pretty heavy already too, but looks ok for a 1.8 maintenance release. Having the "macos-catalina" topic in a pre1 would ne nice.
[17:32:09] <meffie> we can have the ones we will never merge as "abandoned", it would help. they can always be reopened later if for some reason  we change our mind, no?
[17:32:09] <wiesand> Mike: Thanks, will do.
[17:34:39] <wiesand> so, if you have some time to burn, please start reviewing https://gerrit.openafs.org/#/q/status:open+project:openafs+branch:master+topic:macos-catalina
[17:35:17] <meffie> excellent, will do. i think yadayada has already reviewed these?
[17:36:28] <wiesand> er, no, looks like most of those had no review at all yet
[17:36:28] <yadayada> yes I had some comments on some of them. I hope those will be resolved soon.
[17:36:34] <meffie> also, marcio added a new buildbot worker for macos10.15.  it is working but needs those changes in the catalina topic to build. i should demote until those are in?
[17:37:41] <wiesand> I'd hope they won't take that long to get in.
[17:39:40] <meffie> ok i invited yadayada to review
[17:39:45] <wiesand> Alas: "Builder macos10-15-x86_64 failed (failed compile (failure))" is the verdict on 13668 - looks like this tack needs more work
[17:41:12] <meffie> well, i think stack builds
[17:41:50] <meffie> Builder macos10-15-x86_64 succeeded (build successful) - https://buildbot.openafs.org/#builders/48/builds/7
[17:42:25] <meffie> but yeah some of the gerrit do not build until all the changes are merged.
[17:42:58] <wiesand> In file included from /Users/buildbot/workers/openafs/macos10-15-x86_64/build/include/afs/afs_sysnames.h:25:
/Users/buildbot/workers/openafs/macos10-15-x86_64/build/include/afs/stds.h:20:10: fatal error: 'sys/types.h' file not found
#include <sys/types.h>
         ^~~~~~~~~~~~~
1 error generated.
[17:43:26] <meffie> the top gerrit is currently 13928
[17:43:54] <meffie> i think the subject names are confusing, i agree.
[17:44:18] <meffie> i'll put that in the review.
[17:44:48] <wiesand> ah, looks like 13668 is not based on 13936
[17:44:54] <meffie> correct.
[17:45:05] mbarbosa leaves the room
[17:45:49] <meffie> you can see the order in "related changes"
[17:46:23] <wiesand> those are ordered by dependencies?
[17:46:41] <meffie> yes
[17:46:44] <meffie> cc388d8802 (gerrit/changes/28/13928/2) macos: add entry for afs into synthetic.conf
d3497bd441 (gerrit/changes/71/13671/3) macos: add script to notarize OpenAFS
502e0474d5 (gerrit/changes/70/13670/3) macos: prepare for notarization
21cdcfd871 (gerrit/changes/35/13935/2) macos: upgrade *.xib files
5715829363 (gerrit/changes/36/13936/3) macos: let compiler knows location of /usr/include
2731be4116 (gerrit/changes/69/13669/2) macos: packaging support for MacOS X 10.15
906f0593f0 (gerrit/changes/68/13668/2) macos: add support for MacOS 10.15
4a9078c6bb (origin/master, origin/HEAD, gerrit/master, gerrit/changes/33/13933/2, report/merged/master, m) afs: Avoid giving wrong 'tf' to afs_InitVolSlot
[17:48:21] <meffie> i think it would be better for the top one to be named "macos: add support for MacOS 10.15"
[17:49:25] <meffie> i'll put that in the reviews.
[17:49:58] <wiesand> thanks
[17:53:14] <wiesand> The weekend will be rainy. I scheduled some time for openafs. So hopefully there'll be more to discuss from my p.o.v. next week.
[17:53:47] <wiesand> Anything else to discuss today?
[17:54:13] <wiesand> NB Thanks a lot for starting the meeting w/o me being present.
[17:54:36] <meffie> i am currently looking at the old gerrit 2288 and pushed rebase for it, since ben mentioned jhutz was asking about it a few weeks ago
[17:54:59] <yadayada> I am working on some system crash on hardened kernel mainly due to hardening of copy_to_user functions. Still at very early stage of analysis. May be next time will have better picture on it
[17:55:10] <meffie> ok, thanks.
[17:55:43] <yadayada> nothing from my side for today
[17:56:11] <wiesand> 2288 sounds a bit risky
[17:56:54] <meffie> not sure. seems less risky than what we do now :)
[17:57:23] <wiesand> yikes
[17:57:28] <meffie> :)
[17:58:04] <meffie> apparently this change has been in use for a long time without issue, so it could be ok.
[17:58:37] <meffie> my immediate interest is for fast startups for testing purposes.
[17:58:44] <wiesand> Well I used fileserver fast-restart for a long time w/o issues either…
[17:59:26] <wiesand> But still was told it's plain evil…
[17:59:43] <meffie> oh, also, i rebased the linux-native-mount patches to the current master
[18:00:17] <meffie> and those are ready for more review. maybe yadayada is interested?
[18:00:49] <wiesand> Good. Getting that going would be really nice.  Thanks!
[18:01:07] <meffie> topic:linux-native-mounts
[18:01:42] <meffie> they seem to be working well for me.
[18:02:24] <yadayada> linux native mounts I have tried, had some finding and shared with Andrew, but overall it works well for me
[18:03:00] <meffie> thanks. can i invite you to review the changes?
[18:03:08] <wiesand> Let's adjourn. Sorry again for being late today - I still have to get used to the new time slot (and find a way not to fall asleep before the meeting ;-)
[18:03:08] <yadayada> sure
[18:03:31] <yadayada> Thanks All !!
[18:03:40] <meffie> done. thanks!
[18:03:44] <wiesand> Thanks a lot!
[18:03:50] wiesand leaves the room
[18:03:58] meffie leaves the room
[18:09:56] mbarbosa joins the room
[18:13:10] yadayada leaves the room
[18:13:31] mbarbosa leaves the room
[18:13:34] mbarbosa joins the room
[18:51:21] mbarbosa leaves the room
[18:51:27] mbarbosa joins the room
[18:58:08] mbarbosa leaves the room
[18:58:13] mbarbosa joins the room
[19:06:40] meffie joins the room
[19:20:16] mbarbosa leaves the room
[19:20:17] mbarbosa joins the room
[20:36:26] mbarbosa leaves the room
[20:56:14] mbarbosa joins the room
[21:45:52] mbarbosa leaves the room
[22:34:18] meffie leaves the room