- Wednesday, April 13, 2016

release-team@conference.openafs.org

Wednesday, April 13, 2016< ^ >

Room Configuration

Room Occupants

GMT+0
[02:43:57] kadukoafs@gmail.com/barnowl8C9386CA joins the room
[02:57:14] <kadukoafs@gmail.com/barnowl8C9386CA> I seem to have a viral infection of some sort and may need to sleep
through the meeting.
[03:52:43] <Jeffrey Altman> feel better
[10:10:54] wiesand joins the room
[10:12:11] wiesand leaves the room
[13:20:43] meffie joins the room
[13:58:04] Daria joins the room
[13:58:17] Daria waves
[13:58:25] <meffie> get well soon. sleep and lots of water.
[13:58:58] meffie waves back
[13:59:41] wiesand joins the room
[14:00:04] <wiesand> Hi
[14:00:25] <meffie> hello wiesand
[14:01:15] <wiesand> I think we’re getting closer to 1.6.18pre1 :)
[14:01:30] <mvita> yay!
[14:01:48] <wiesand> I won’t manage to get it out today, but hopefully this week.
[14:01:51] <meffie> yay
[14:02:41] <wiesand> I think everything on the candidate list had review that - with a little bit of good will - can be called sufficient.
[14:03:24] <wiesand> So  I think I’ll merge them if there’s no veto or "Hey, wait" today.
[14:04:06] <wiesand> Obviously, a look at the latest PS for NEWS would be nice. (12242)
[14:04:57] <mvita> looking
[14:04:59] <wiesand> Pullups of the vcache changes are 12256/7. Well, no +1s here yet.
[14:05:31] <meffie> ok, thanks.
[14:06:01] <wiesand> But there seems to be very little skew wrt master.
[14:06:45] <wiesand> 12252 is so simple that I’m fine merging it w/o further review.
[14:07:10] <wiesand> 12089 should be ok
[14:07:50] <wiesand> And the four changes under https://gerrit.openafs.org/#/q/status:open+project:openafs+branch:openafs-stable-1_6_x+topic:dcache-32bit-overflow should be good to go as well.
[14:08:23] <wiesand> And I think that would be 1.6.18pre1.
[14:09:54] <wiesand> Comments welcome.
[14:10:17] <meffie> do you need more reviewers for 12089?
[14:10:43] <wiesand> I’d be a bit more comfortable.
[14:11:00] <mvita> I'm looking at that one right now
[14:11:07] <wiesand> But wouldn’t want to delay pre1 again for it.
[14:11:22] <mvita> oh, I already reviewed it.
[14:11:42] <mvita> ps1, looking at ps2 now
[14:12:25] <mvita> I'm still fumbling with the new gerrit interface - especially when comparing patchsets
[14:13:34] <meffie> upper right, there's an icon to switch to unified diff.
[14:14:33] <mvita> yeah
[14:15:07] <meffie> and "diff against" pulldown.
[14:15:22] <mvita> I mean the little "Patch Set" list at the top of each pane - it's impossible to tell which one is selected
[14:15:35] <mvita> I end up checking the URL to make sure I got what I want
[14:16:48] <wiesand> The Patch Set list works fine in my Safari
[14:18:03] <meffie> you mean Patch Set (2/2) or Patch Set (1/2) ?
[14:18:16] <mvita> yes
[14:19:10] <meffie> Patch Set (1/2) means you've selected 1 (out of 2)
[14:19:26] <mvita> obviously
[14:19:37] <meffie> so it's not impossible to tell :)
[14:19:48] <mvita> that's not how it displays
[14:20:26] <mvita> it displays   "Patch Set   1    2      (mystery icon 1) (mystery icon 2)"
[14:20:59] <mvita> and I can't distinguish whether 1 or 2 is higlighted - they look identical to me
[14:21:11] <mvita> oh, and "Base"
[14:21:28] <mvita> "Patch Set Base  1 2 (mystery icon 1) (mystery icon 2)
[14:21:40] <mvita> never mind, it's clearly just me or my browser
[14:21:58] <meffie> yes, i dont see that.
[14:22:12] <wiesand> Mike: in the diff view, at the top
[14:23:03] <meffie> ah.
[14:23:08] <wiesand> No mystery icon 2 here though. And the selected one has a different background for me.
[14:23:11] <mvita> and when I select 1 in one pane and 2 in another - it shows me a diff from a different patch.
[14:23:24] <wiesand> Mystery icon 1 has a tooltip saying "Download"
[14:24:46] <mvita> sorry to derail your meeting, I'll figure it out later.
[14:24:51] <meffie> ah i see.  nice, you and see diffs between patchset directly in the diff view.
[14:26:07] <meffie> that is "you can see"
[14:26:33] <wiesand> and in the case of 12089 it’s just the difference in the context
[14:27:28] <wiesand> because the change itself hasn’t changed
[14:28:32] <wiesand> this is the extra work i meant, which we get by accumulating changes with path conflicts
[14:29:44] <meffie> yes, and yes.
[14:32:37] <meffie> ok sorry for the digression.
[14:33:07] <wiesand> are you still reviewing?
[14:33:39] <mvita> trying to
[14:33:47] <mvita> very frustrated right now
[14:34:12] <mvita> (not with you, w/ gerrit and myself)
[14:35:51] <mvita> I'm looking at 12089 and it keeps pulling in diffs from 12113
[14:36:08] <mvita> I don't understand what I'm doing wrong
[14:36:11] <meffie> yes, it was rebased.
[14:36:29] <wiesand> You’re not doing anything wrong.
[14:36:37] <meffie> so you see the changes since the rebase.
[14:37:17] <meffie> correct, your are not doing anything wrong.
[14:38:04] <mvita> OH.  ps2 is merely a rebase of ps1, no other changes?
[14:38:10] <meffie> yes
[14:38:24] <mvita> @@@@@@@@@@@@@@@@@@@@@@@@@@@
[14:38:40] <meffie> "Patch Set 2: Patch Set 1 was rebased"
[14:38:42] <wiesand> Which is why you don’t see the actual change when comparing PS1 and PS2 ;-)
[14:39:16] <mvita> mike, those soft pretzels are looking better all the time
[14:39:24] <meffie> yummy
[14:40:35] <meffie> moving on?
[14:40:52] <mvita> yes, please before I have an aneurysm
[14:40:59] <wiesand> If everybody is done reviewing....
[14:41:08] <meffie> yes
[14:41:14] <wiesand> But what to?
[14:41:25] <wiesand> No Ben, sadly
[14:41:50] <meffie> yes, get well soon Ben.
[14:41:53] <wiesand> And I think we’re done with 1.6
[14:42:32] <meffie> i'll see if we can round up any pre1 testers.
[14:42:53] <wiesand> that would be good
[14:43:04] <wiesand> I’ll try to get it done tomorrow.
[14:43:36] <wiesand> Anything else to discuss today?
[14:43:53] <mvita> not that I can think of
[14:44:14] <meffie> i do not, thank you.
[14:44:29] <wiesand> Ok, thanks a lot!
[14:44:38] <mvita> thanks Stephan!
[14:44:43] <wiesand> Bye
[14:44:45] wiesand leaves the room
[14:44:50] meffie leaves the room
[15:07:46] meffie joins the room
[15:08:10] meffie leaves the room
[20:11:39] Jeffrey Altman leaves the room
[21:54:29] Jeffrey Altman joins the room
[22:20:15] mvita leaves the room