- Monday, May 12, 2014

openafs@conference.openafs.org

Monday, May 12, 2014< ^ >

Room Configuration

Room Occupants

GMT+0
[09:09:57] Simon Wilkinson joins the room
[12:29:14] Marc Dionne joins the room
[13:27:53] mvita joins the room
[14:57:06] dwbotsch leaves the room
[15:25:27] dwbotsch joins the room
[15:56:04] meffie joins the room
[18:40:07] kaduk joins the room
[18:41:23] <kaduk> Anyone want to sanity check that the call to er_Proc_CodeGeneration() in gerrit 3305 does not logically belong in the xflags block it's in?
[19:01:31] <meffie> it's hard to say, the commit msg doenst seem to match the diff, from a quick peek.
[19:02:40] <meffie> you are referring to the hunk in rpc_main.c?
[19:03:09] <kaduk> Yes.
[19:04:52] <meffie> looks like it was intentional, but seems odd.
[19:04:56] <kaduk> (I'm playing around with moving the function list to the generated header, as discussed in gerrit 11095.)
[19:05:40] <kaduk> If I move the whole xflag block (including the er_Proc_CodeGeneration() call), it doesn't build, since the code generated by er_Proc_CodeGeneration() relies on functions in the C file.
[19:05:41] <meffie> the comment about that seems to say, this is where we list all the functions, so maybe that's why?
[19:09:15] <kaduk> My current WIP involves passing a char[500][200] as a function argument, which I am not super-excited about.
[19:14:03] <meffie> well, because those should be powers of two, char[512][256], see all better.
[19:14:50] ballbery remembers when that was a good way to crash programs because it would exceed the stack probe...
[19:15:15] <kaduk> I expect it's still a good way to crash programs, on some systems.
[19:18:41] <ballbery> well, passing as an argument is safe because it's a pointer. declaring on the stack used to be quite problematic
[19:18:54] <ballbery> (even ignoring the whole buffer overflow thing)\
[19:18:55] <Jeffrey Altman> I belive er_Proc_CodeGeneration() was placed in the xflag block because the generated names are only used on the server side if the stats code is generated.
[19:22:50] <kaduk> Thanks, Jeff. I guess I can leave it there for now.
[19:53:31] <kaduk> (gerrit 11138 for those who didn't get mail about it)
[20:28:25] meffie leaves the room
[21:06:02] kaduk leaves the room
[23:22:34] mvita leaves the room