[00:40:10] --- Simon Wilkinson has become available [01:12:35] --- deason has left [01:14:24] --- deason has become available [01:49:39] --- Simon Wilkinson has left [02:44:39] --- Simon Wilkinson has become available [04:52:25] --- mvitale has become available [04:58:13] --- Simon Wilkinson has left [05:01:15] --- mvitale has left [05:50:34] --- mvitale has become available [05:59:31] --- mvitale has left [06:35:04] --- mvitale has become available [06:40:53] --- mvitale has left [07:49:16] --- mvitale has become available [08:09:53] --- meffie has become available [08:17:15] --- mvitale has left [08:18:10] --- mvitale has become available [08:26:14] --- mvitale has left [09:20:44] --- mvitale has become available [09:29:38] --- mvitale has left [09:32:09] --- mvitale has become available [10:20:12] So what do I still need to do to get 9978, 9979, 9980, 9989, 9990 merged? I think 9990 probably should get a review from jaltman, but the rest should be ready to go, I think. [10:42:58] as soon as I have time to review I will do so. once they have sufficient review or are deemed trivial by a gatekeeper they will be merged. [10:43:25] --- mvitale has left [10:43:45] Probably I have some more review time today. [10:50:37] --- mvitale has become available [10:53:39] thanks. Jeff, it would be helpful if you'd prioritize 9990 over the others, since I think that one needs review from you in particular. [11:14:37] --- rra has become available [11:14:54] People are having trouble connecting to the room again, so I'm going to restart jabber, probably a couple of times to get it to take. [11:15:24] --- LOGGING STARTED [11:15:30] --- rra has become available [11:15:41] --- jaltman/FrogsLeap has become available [11:16:00] --- meffie has become available [11:16:10] --- stephan.wiesand has become available [11:17:24] --- stephan.wiesand has left [11:18:17] --- shadow@gmail.com/barnowl5ABA57FD has become available [11:23:16] --- stephan.wiesand has become available [11:23:42] --- stephan.wiesand has left [11:23:51] --- stephan.wiesand has become available [11:23:59] --- stephan.wiesand has left [11:24:08] --- Stephan Wiesand has become available [11:25:22] --- Stephan Wiesand has left [11:25:41] --- andersk has become available [11:26:47] --- rra has left [11:28:31] --- stephan.wiesand has become available [11:28:52] --- stephan.wiesand has left [11:37:20] --- kaduk@mit.edu/barnowl has become available [11:37:39] I was wondering who was going to get that number :) [11:38:23] 9990 has been merged [11:43:57] and all of the rest were reviewed either last night or just now. I think all but 9979 are fine [11:45:05] kaduk: on 9989 did you mean +1 code review instead of +1 verified? [11:45:12] Yes, sorry. [11:45:30] I've done that a few other times, too -- the buttons look too similar. [11:53:38] --- mvitale has become available [12:03:00] Jeff, do you think it's worth my (re)looking at 9978 and 9979 now? [12:11:34] I don't see why not [12:35:05] --- jaltman/FrogsLeap has left: Disconnected [12:35:18] --- jaltman/FrogsLeap has become available [12:36:03] The Solaris x86 builder is out of space and as a result builds are failing. [12:38:29] ok [12:58:14] --- ballbery has become available [13:21:41] --- Simon Wilkinson has become available [13:25:15] --- mvitale has left [13:26:37] --- mvitale has become available [13:26:40] --- Simon Wilkinson has left [13:27:24] --- Simon Wilkinson has become available [13:45:31] In 9978, it's a little weird to see if (target == NULL) next to if (target) (as opposed to if (target != NULL)), but I won't insist. [13:47:19] The rough rule of thumb that we adopted last time this came up was that == NULL or !=NULL should be used rather than if (!target) and if (target) [13:47:43] But it's more of a guideline than a hard and fast rule. Whatever makes the code easiest to understand. [13:47:56] Yeah, that's my preference, but it's not worth holding up progress to be a stickler. [13:57:15] --- Simon Wilkinson has left [13:58:46] --- Simon Wilkinson has become available [13:59:56] --- mvitale has left [14:18:05] --- Simon Wilkinson has left [14:19:28] --- Simon Wilkinson has become available [14:24:47] hmm, need to look closer at the solaris 11 x86 slave... [14:27:18] --- Simon Wilkinson has left [14:29:17] --- Simon Wilkinson has become available [14:42:12] --- mvitale has become available [14:59:14] --- Simon Wilkinson has left [15:00:30] --- Simon Wilkinson has become available [15:19:01] --- Simon Wilkinson has left [15:28:03] --- jhutz@jis.mit.edu/owl has become available [15:28:19] I don't expect there to be broken printfs. That feature has pretty much always been there. [15:35:14] --- mvitale has left [15:35:41] --- mvitale has become available [15:35:56] --- mvitale has left [15:42:00] I would expect the feature to be there, yes; I am less confident that it is always correct on some of the more exotic platforms. [15:43:48] It is correct in glibc. I expect it to be correct in any platform that claims POSIX compliance, or ANSI C compliance. I suppose there might be noncompliant embedded implementations that don't work, but I doubt there are any we care about. [15:44:33] I wasn't saying that we should *care*... [15:47:37] OK [16:06:54] --- meffie has left [16:13:17] --- mvitale has become available [17:51:40] --- mvitale has left [19:14:14] --- mvitale has become available [19:58:31] --- mvitale has left [20:17:28] --- mvitale has become available [20:28:34] --- mvitale has left [20:41:48] --- asedeno has become available [23:19:32] --- shadow@gmail.com/barnowl5ABA57FD has left [23:19:44] --- shadow@gmail.com/barnowl5ABA57FD has become available