[05:59:21] --- Roman Mitz has become available [06:01:13] --- mvitale has become available [06:11:01] why is this --whitespace=fix bit necessary ? [06:11:48] Because repositories with trailing whitespace are annoying - it's really easy to end up with commits that change extraneous whitespace [06:12:07] So either you spend a load of time making the whitespace of your commit match whats in the repo, or you have a history where git blame is useless [06:12:39] Just before the 1.6.x branch Marcus Watts provided a script which cleaned all of the "bad" whitespace from the OpenAFS repository. We're now keen not to let any slip back in. [06:17:55] something which, in a just world, would just be handled by a central server. but that's not the model. [06:17:57] --- Simon Wilkinson has left [06:42:39] hmm, k [06:43:16] so at what point during the whole process does one need to run the --whitespace command (in other words, someone who knows about these things should update the afslore git page) [06:46:27] think of it this way. prior to submitting to gerrit you should be reviewing your patch for errors. "git diff" is one way of reviewing them. If there are errors, such as whitespace, or indentation, or typos in comments, or other, they need to be fixed prior to pushing the patchset to gerrit. [06:46:48] what if we're talking completely new files? [06:47:10] same thing. [06:47:24] git diff won't help me, tho [06:47:33] "git show HEAD" [06:47:47] "git log -p HEAD" [06:47:59] well, you can do git diff —check which will warn of whitespace on uncommitted work [06:48:02] I'm saying, git diff won't expose whitespace errors/etc [06:48:10] hmm [06:49:12] what I'd like is to have my editor (vim) configured to show "bad" whitespace while I work; but I haven't taken the time to do that yet [07:03:57] hrm... vim's c_space_errors and java_space_errors don't seem to do anything [07:34:13] --- deason has become available [07:34:49] --- abo has left [07:40:01] --- abo has become available [07:43:30] --- Derrick Brashear has left [08:01:16] --- Derrick Brashear has become available [08:10:12] there's also a git pre-commit hook to check for whitespace errors... [08:10:34] I'm not sure where I got that; I assume it was the sample pre-commit hook [08:58:43] --- Derrick Brashear has left [09:47:03] --- Derrick Brashear has become available [10:54:50] --- Derrick Brashear has left [10:55:12] --- Derrick Brashear has become available [12:04:48] --- Simon Wilkinson has become available [12:06:21] I have a vim hook which highlights "bad" whitespace in red. Sadly, it doesn't work in mvim for some reason. [12:32:45] --- dev-zero@jabber.org has become available [13:48:34] --- Roman Mitz has left [13:57:54] --- dev-zero@jabber.org has left [14:34:15] --- Derrick Brashear has left [14:52:51] --- Derrick Brashear has become available [15:30:03] --- mvitale has left [15:54:05] --- deason has left [18:42:21] --- kula has left: Lost connection [19:10:46] --- kula has become available [21:41:48] --- kula has left: Lost connection [21:54:19] --- kula has become available [22:02:15] --- dev-zero@jabber.org has become available [22:02:50] --- dev-zero@jabber.org has left [22:03:02] --- dev-zero@jabber.org has become available [22:13:52] --- dev-zero@jabber.org has left: Lost connection [22:13:52] --- kula has left: Lost connection [22:19:27] --- dev-zero@jabber.org has become available [22:25:45] --- kula has become available [23:29:51] --- dev-zero@jabber.org has left [23:30:20] --- Simon Wilkinson has left [23:31:39] --- Simon Wilkinson has become available [23:33:07] --- Simon Wilkinson has left [23:55:38] --- dev-zero@jabber.org has become available