[00:06:49] --- reuteras has left [00:41:41] --- reuteras has become available [04:22:23] --- pod has become available [05:15:41] --- meffie has become available [05:57:10] --- jaltman has left: Disconnected [05:57:19] --- jaltman has become available [06:08:54] --- reuteras has left [07:15:41] --- deason has become available [07:59:55] --- jaltman has left: Replaced by new connection [07:59:56] --- jaltman has become available [08:17:49] --- jaltman has left: Disconnected [08:17:59] --- jaltman has become available [09:41:39] --- jaltman has left: Disconnected [10:14:45] --- rra has become available [10:19:39] --- jaltman has become available [10:25:24] --- edgester has become available [12:36:48] --- jaltman has left: Disconnected [13:08:39] --- edgester has left [13:11:50] --- jaltman has become available [14:18:13] --- canehan has left [14:42:43] --- meffie has left [15:47:59] --- deason has left [16:40:42] So, uh, VREFCOUNT() uses the vcache refCount but VREFCOUNT_GT uses the vnode's usecount? #if defined(AFS_DARWIN80_ENV) #define VREFCOUNT_GT(v, y) vnode_isinuse(AFSTOV(v), (y)) #elif defined(AFS_XBSD_ENV) || defined(AFS_DARWIN_ENV) #define VREFCOUNT(v) ((v)->vrefCount) #define VREFCOUNT_GT(v, y) (AFSTOV(v)->v_usecount > (y)) #elif defined(AFS_LINUX24_ENV) #define VREFCOUNT(v) atomic_read(&(AFSTOV(v)->v_count)) #define VREFCOUNT_GT(v, y) (VREFCOUNT(v)>y) [16:42:10] what's vrefCount defined as? [16:42:20] (this is not a trick question) [16:44:15] v_usecount. But then VREFCOUNT takes a vnode and VREFCOUNT_GT takes a vcache? [16:44:34] Or rather, v->v_usecount. [16:52:04] notably, AFSTOV [16:52:49] I would be a horrible person if I did #define VREFCOUNT (ASSERT_VI_LOCKED(v, "must lock interlock"),(v)->vRefCount) wouldn't I? [16:53:13] well, if you wanna fix everything it finds, go nuts [16:53:46] I mean, eventually I should go and audit the locking on all the vnode members. (We seem to hardly use the interlock at all, which is bad.) [16:54:16] it is/was on my list of things to do. i am doing badly at getting to it [16:54:55] Unrelatedly, rwatson and pjd suggested (as a long-term thing) integrating with the freebsd namecache. I suppose I could make an RT ticket ... "let's see if I remember my password". [17:29:54] --- meffie has become available [17:54:00] --- deason has become available [18:14:45] --- rra has left: Disconnected [18:34:57] --- Russ has become available [18:50:13] --- meffie has left [22:38:05] --- deason has left [23:42:55] --- Russ has left: Disconnected