[00:42:13] --- Simon Wilkinson has become available [00:47:41] Russ: Yeah. [00:47:57] UKERNEL/sysincludes.h does a #define user usr_user [00:48:08] But sys/user.h also defined 'struct user', and so we go boom. [00:49:29] I suspect you can just remove the #define, though. [01:07:10] --- Simon Wilkinson has left [01:54:57] --- Simon Wilkinson has become available [01:55:38] http://gerrit.openafs.org/2838 [02:38:00] --- haba has become available [04:22:36] --- kula has become available [04:37:19] --- jaltman has become available [05:15:26] --- haba has left [05:36:53] --- haba has become available [05:43:42] --- Simon Wilkinson has left [06:17:22] --- Simon Wilkinson has become available [08:02:38] --- jaltman has left: Disconnected [08:24:14] --- Simon Wilkinson has left [08:24:14] --- Simon Wilkinson has become available [08:59:11] --- reuteras has left [08:59:16] --- reuteras has become available [09:04:41] --- reuteras has left [09:04:58] --- jaltman has become available [09:05:54] --- haba has left [09:57:09] --- jaltman has left: Disconnected [11:34:40] --- jaltman has become available [11:41:10] --- jaltman has left: Disconnected [11:46:33] --- rra has become available [12:10:12] Cool, thanks! [12:10:15] I'll pull that up to 1.6. [12:20:31] There's an RX window size change that I've just pushed that we'll need for 1.6, too. [12:55:57] --- jaltman has become available [14:14:20] --- Simon Wilkinson has left [14:56:34] --- Simon Wilkinson has become available [15:26:13] --- jaltman has left: Disconnected [16:22:47] --- jaltman has become available [16:24:19] --- jaltman has left: Disconnected [16:39:12] --- Simon Wilkinson has left [16:39:12] --- Simon Wilkinson has become available [16:46:02] --- jaltman has become available [17:10:34] --- Simon Wilkinson has left [17:47:36] --- Russ has become available [17:51:48] --- jaltman has left: Disconnected [17:51:53] --- jaltman has become available [18:10:15] --- jaltman has left: Disconnected [19:17:17] rra: I just noticed that debian/dkms.conf.in will probably break when DKMS gets correct shell quoting. It needs more backslashes so that it is interpreted as one statement: MAKE[0]="(./configure --enable-disconnected --with-linux-kernel-packaging \ - --with-linux-kernel-headers=${kernel_source_dir} + --with-linux-kernel-headers=${kernel_source_dir} \ - && make + && make \ && mv src/libafs/MODLOAD-*/openafs.ko .)" [19:19:25] Hm, why would it break later when it's working now? I don't really understand the shell quoting rules. [19:20:43] And wouldn't backslashes added like that just get eaten by the double quotes and not mean anything? [19:22:01] Basically, because $ cmd="(echo foo && echo bar)" $ eval $cmd foo bar $ eval "$cmd" bash: syntax error near unexpected token `&&' [19:22:49] The current string has a newline before the &&, which only works because dkms still has enough quoting bugs that turn newlines into spaces. [19:23:09] Ah, yeah, I see. [19:23:12] Okay, I'll fix. [19:23:17] --- kula has left [19:55:46] --- shadow@gmail.com/owlEBE83A21 has become available [21:59:00] --- reuteras has become available [22:32:42] --- Russ has left: Disconnected [22:47:27] --- jaltman has become available [23:27:24] --- Simon Wilkinson has become available