[00:09:00] --- Russ has left: Disconnected [00:50:10] --- haba has left [01:28:16] --- haba has become available [01:37:44] --- dev-zero@jabber.org has left [02:40:20] --- dev-zero@jabber.org has become available [03:31:15] --- sxw laptop has become available [03:41:37] --- sxw laptop has left [03:56:01] --- haba has left [04:55:55] --- mmeffie has become available [05:10:36] --- mmeffie has left [05:31:05] --- reuteras has left [05:32:41] --- reuteras has become available [05:38:53] --- sxw laptop has become available [05:59:26] --- sxw laptop has left [06:34:23] --- stevenjenkins has left [06:42:08] please try /afs/athena.mit.edu/user/j/a/jaltman/Public/OpenAFS/rpc_cout-1.patch This is a continuation of Andrew's work. It removes all of the warnings on Windows. Does it do the same on Unix? [06:50:32] apply over his, then? [06:52:24] apply instead of his [06:53:56] yeah, after browsing the failed hunks i gathered that [07:08:48] we need to split AFS_64BITPOINTER_ENV into kernel and user versions of same [07:09:59] of course the only userspace code that uses it is util/snprintf.c [07:19:20] --- deason has become available [07:38:55] --- reuteras has left [07:48:51] jaltman: that appears to get rid of at least all of the warnings mine did, on unix [07:49:21] it still deliberately does obj->foo, not &obj->foo when obj->foo is an array, which I find odd, but it works when you cast it like that [07:53:22] I want to revisit that in the future but I don't have time right now to perform the necessary analysis. [07:54:05] feel free to submit my patch to gerrit as an update to yours. you did the majority of the work. [09:06:30] --- Jeffrey Altman has left [09:06:46] --- Russ has become available [09:54:45] --- jaltman has left: Replaced by new connection [09:54:46] --- jaltman has become available [10:20:47] --- Russ has left: Disconnected [10:51:53] deason, i merged jeff's patch with yours and pushed, but it's on top of my warning patch. i can rebase if we want to push in the other order [10:52:00] verify if you get a moment [11:08:16] actually, I've got something I was just verifying, if you want one without a dependency [11:08:43] 666 will conflict with 647, btw, on the AFS_SIZET_FMT definition [11:13:39] ok. um. that's unfortunate as i have no idea how these will end up sequenced [11:15:02] --- sxw laptop has become available [11:16:23] --- dev-zero@jabber.org has left [11:19:35] seeing if i can sequence in 647 between 666 and 664 [11:23:03] Just push, and then let the unlucky submitter pick up the pieces? [11:24:02] i am one of those submitters. by claiming 664 from andrew with jeff's patch i am about to make myself 2 of them [11:24:18] that's fine too; but I didn't mean it was some unrelated thing that happens to conflict; you're doing the same thing 647 is trying to solve [11:25:05] not sure: remember that on darwin it's possible to have 2 different pointer models in pkay at once [11:26:34] yeah, but I thought from the discussions earlier we established that we can't reliably determine the formatter for size_t just on preprocessor symbols [11:26:53] that's a different issue than this one, but yeah [11:27:04] in general, yes. [11:27:38] Yeh. %zu is the way to go there, where we can. [11:27:39] it may be that 647 solves this for now and i can avoid that [11:27:43] well, I thought you might like avoiding needing to do that AFS_64BIT_SIZEOF stuff; it didn't seem like you like it, heh [11:27:59] if i can avoid doing it for now, i will. verifying [11:28:13] (from the "+#define AFS_64BIT_SIZEOF 1 /* seriously? */" :) [11:28:28] at some point we will need better support for "mixed 64/32 32/64 64/64" platforms [11:32:44] 664 indeed verifies, though, fwiw [11:33:56] not shocking. i'm not pushing it until simon's happy with it [11:34:47] 666 makes me very happy. In particular ... [11:34:52] - ubik_Call [11:35:17] Ah, but there's + ubik_Call later on. Boo. [11:39:41] yeah yeah yeah [11:39:52] it does eliminate ubik_Call_New... what do you want? [11:40:05] When folk submit patches that remove all of the warnings in a file, can they also update README.WARNINGS, the Makefile.in for the directory that the file lives in, and the Makefile.in for any of the shared directories that also build it? [11:40:23] There's a few slipped past that haven't caught all of these ... [11:40:32] it's not clear i have removed all the warnings. i did on *my platform* but how do i know i did it everywhere? [11:40:47] Include those changes in your patch. [11:40:52] Let others verify. [11:40:59] If they moan, revert those changes. [11:41:09] Otherwise, we'll end up with warnings inhibited for ever ... [11:41:11] (of course, nominally the places i removed, were already warning-free files haha) [11:41:14] "haha" [11:41:19] Yeh. hahaha [11:41:29] That's why we need buildbot [11:41:33] Maybe this weekend. [11:42:22] this weekend i will work until i am too drunk to continue [11:43:53] You're working for a brewery> [11:43:56] ? [11:46:58] Right, I have now used up my hour's quota of -1s. I'm off for dinner! [11:47:58] --- dev-zero@jabber.org has become available [11:48:08] I'll verify 647 when I get back, if it needs more testing ... [11:48:12] --- dev-zero@jabber.org has left [11:48:27] --- dev-zero@jabber.org has become available [11:54:44] --- dev-zero@jabber.org has left: Replaced by new connection [11:54:59] --- dev-zero@jabber.org has become available [12:00:36] --- dev-zero@jabber.org has left: Replaced by new connection [12:00:49] --- dev-zero@jabber.org has become available [12:04:41] --- dev-zero@jabber.org has left [12:04:47] i'll be touring western pa vinyards; someone else is driving, so i can work [12:05:05] --- dev-zero@jabber.org has become available [12:07:58] --- dev-zero@jabber.org has left: Replaced by new connection [12:07:59] --- dev-zero@jabber.org has become available [12:22:34] --- mmeffie has become available [12:23:27] --- dev-zero@jabber.org has left [12:23:39] --- dev-zero@jabber.org has become available [13:47:17] --- haba has become available [14:56:00] --- sxw laptop has left [15:39:14] --- deason has left [15:44:31] --- mmeffie has left [15:46:20] --- haba has left [17:15:00] --- deason has become available [17:29:15] --- Russ has become available [17:46:49] --- Russ has left: Replaced by new connection [17:46:49] --- Russ has become available [17:48:22] --- Russ has left: Replaced by new connection [17:48:22] --- Russ has become available [18:23:59] --- Russ has left: Replaced by new connection [18:24:00] --- Russ has become available [18:33:59] --- jaltman has left: Disconnected [19:18:56] --- asedeno has left [19:19:00] --- asedeno has become available [19:58:46] --- jaltman has become available [21:45:06] --- deason has left [22:11:15] --- jaltman has left: Replaced by new connection [22:11:16] --- jaltman has become available [22:27:40] --- reuteras has become available [22:57:30] --- Russ has left: Disconnected [22:58:07] --- Russ has become available [23:02:46] --- Russ has left: Replaced by new connection [23:02:47] --- Russ has become available [23:57:33] --- Russ has left: Replaced by new connection [23:57:34] --- Russ has become available